Differences

This shows you the differences between two versions of the page.

--- principles:single_level_of_abstraction [2021-09-02 10:46] – old revision restored (2021-05-11 22:26) 65.21.179.175
+++ principles:single_level_of_abstraction [2021-09-02 18:14] – old revision restored (2021-05-11 22:25) 65.21.179.175
@@ Line 12: / Line 12: @@
 ===== Principle Statement =====
-Each method should be written in terms of a single level of abstraction.
+Each method should be written in terms of a single level of abstraction
@@ Line 19: / Line 19: @@
 All statements of a method should belong to the same level of abstraction. If there is a statement which belongs to a lower level of abstraction, it should go to a private method which comprises statements on this level. Doing so will result in smaller methods.
-Often the body of a loop can be extracted resulting in a separate private method. Loops should ideally contain a single statement (usually a method call). Sometimes this is not achievable without other drawbacks but certainly large loop bodies can be considered a small.
+Often the body of a loop can be extracted resulting in a separate private method. Loops should ideally contain a single statement (usually a method call). Sometimes this is not achievable without other drawbacks but certainly large loop bodies can be considered a smell.
 A further indicator for a missing method is the combination of a blank line, a comment and a block of code. In most of the cases the code block should go to a new private method. This also makes the comment obsolete as the new method carries a name which typically resembles the comment.
@@ Line 104: / Line 104: @@
 }
-private ResultDto toDto(ResultEntity) {
+private ResultDto toDto(ResultEntity entity) {
     ResultDto dto = new ResultDto();
     dto.setShoeSize(entity.getShoeSize());