Differences

This shows you the differences between two versions of the page.

--- principles:single_level_of_abstraction [2020-10-12 12:36] – old revision restored (2015-11-23 13:11) 159.69.186.191
+++ principles:single_level_of_abstraction [2020-10-12 12:36] – old revision restored (2014-07-02 21:07) 159.69.186.191
@@ Line 19: / Line 19: @@
 All statements of a method should belong to the same level of abstraction. If there is a statement which belongs to a lower level of abstraction, it should go to a private method which comprises statements on this level. Doing so will result in smaller methods.
-Often the body of a loop can be extracted resulting in a separate private method. Loops should ideally contain a single statement (usually a method call). Sometimes this is not achievable without other drawbacks but certainly large loop bodies can be considered a smell.
+Often the body of a loop can be extracted resulting in a separate private method. Loops should ideally contain a single statement (usually a method call). Sometimes this is not achievable without other drawbacks but certainly large loop bodies can be considered a small.
 A further indicator for a missing method is the combination of a blank line, a comment and a block of code. In most of the cases the code block should go to a new private method. This also makes the comment obsolete as the new method carries a name which typically resembles the comment.