Differences

This shows you the differences between two versions of the page.

--- principles:single_level_of_abstraction [2018-04-23 09:39] – christian
+++ principles:single_level_of_abstraction [2020-09-09 15:26] – old revision restored (2014-07-01 11:12) 116.202.228.169
@@ Line 1: / Line 1: @@
 ====== Single Level of Abstraction (SLA) ======
-===== Variants and Alternative Names =====
+===== Variants and Alternative Names =====
   * One Level of Abstraction
@@ Line 19: / Line 19: @@
 All statements of a method should belong to the same level of abstraction. If there is a statement which belongs to a lower level of abstraction, it should go to a private method which comprises statements on this level. Doing so will result in smaller methods.
-Often the body of a loop can be extracted resulting in a separate private method. Loops should ideally contain a single statement (usually a method call). Sometimes this is not achievable without other drawbacks but certainly large loop bodies can be considered a smell.
+Often the body of a loop can be extracted resulting in a separate private method. Loops should ideally contain a single statement (usually a method call). Sometimes this is not achievable without other drawbacks but certainly large loop bodies can be considered a small.
 A further indicator for a missing method is the combination of a blank line, a comment and a block of code. In most of the cases the code block should go to a new private method. This also makes the comment obsolete as the new method carries a name which typically resembles the comment.
@@ Line 36: / Line 36: @@
 ===== Caveats =====
-See section [[#contrary principles]].
+An exception where it may be helpful not to adhere to the principle are certain algorithms. When implementing for instance a sorting algorithm, keeping the algorithm together can be considered more readable than splitting it up into several small functions. This is because certain algorithms are well known and splitting them up may disguise them. A suitable compromise has to be found in such a case.
+See section [[#contrary principles]] for further aspects.
@@ Line 104: / Line 106: @@
 }
-private ResultDto toDto(ResultEntity entity) {
+private ResultDto toDto(ResultEntity) {
     ResultDto dto = new ResultDto();
     dto.setShoeSize(entity.getShoeSize());
@@ Line 115: / Line 117: @@
 Now there are two smaller methods each of which is written in terms of a single level of abstraction. This is better readable as no mental grouping is necessary. Furthermore the two methods are still separately understandable ([[Principle of Separate Understandability|PSU]]) so no mental inlining is necessary and if you don't care about the details of the ''toDto'' method, you can just read and understand ''buildResult'' without being distracted by unnecessary detail.
-==== Example2: Comment Plus Code Block ====
+==== Example2: Commented Code Blocks ====
-==== Example3: Parameter Checking ====
+==== Example3: Algorithms ====
-==== Example4: Extracting Classes ====
 ===== Description Status =====